refactor: Simplify repository classes by inheriting from BaseRepository and removing redundant methods

app/repositories/sound.py

@@ -1,33 +1,22 @@
 """Sound repository for database operations."""
 
-from typing import Any
-
-from sqlalchemy import desc, func
+from sqlalchemy import func
 from sqlmodel import select
 from sqlmodel.ext.asyncio.session import AsyncSession
 
 from app.core.logging import get_logger
 from app.models.sound import Sound
+from app.repositories.base import BaseRepository
 
 logger = get_logger(__name__)
 
 
-class SoundRepository:
+class SoundRepository(BaseRepository[Sound]):
     """Repository for sound operations."""
 
     def __init__(self, session: AsyncSession) -> None:
         """Initialize the sound repository."""
-        self.session = session
-
-    async def get_by_id(self, sound_id: int) -> Sound | None:
-        """Get a sound by ID."""
-        try:
-            statement = select(Sound).where(Sound.id == sound_id)
-            result = await self.session.exec(statement)
-            return result.first()
-        except Exception:
-            logger.exception("Failed to get sound by ID: %s", sound_id)
-            raise
+        super().__init__(Sound, session)
 
     async def get_by_filename(self, filename: str) -> Sound | None:
         """Get a sound by filename."""
@@ -59,48 +48,6 @@ class SoundRepository:
             logger.exception("Failed to get sounds by type: %s", sound_type)
             raise
 
-    async def create(self, sound_data: dict[str, Any]) -> Sound:
-        """Create a new sound."""
-        try:
-            sound = Sound(**sound_data)
-            self.session.add(sound)
-            await self.session.commit()
-            await self.session.refresh(sound)
-        except Exception:
-            await self.session.rollback()
-            logger.exception("Failed to create sound")
-            raise
-        else:
-            logger.info("Created new sound: %s", sound.name)
-            return sound
-
-    async def update(self, sound: Sound, update_data: dict[str, Any]) -> Sound:
-        """Update a sound."""
-        try:
-            for field, value in update_data.items():
-                setattr(sound, field, value)
-
-            await self.session.commit()
-            await self.session.refresh(sound)
-        except Exception:
-            await self.session.rollback()
-            logger.exception("Failed to update sound")
-            raise
-        else:
-            logger.info("Updated sound: %s", sound.name)
-            return sound
-
-    async def delete(self, sound: Sound) -> None:
-        """Delete a sound."""
-        try:
-            await self.session.delete(sound)
-            await self.session.commit()
-            logger.info("Deleted sound: %s", sound.name)
-        except Exception:
-            await self.session.rollback()
-            logger.exception("Failed to delete sound")
-            raise
-
     async def search_by_name(self, query: str) -> list[Sound]:
         """Search sounds by name (case-insensitive)."""
         try:
@@ -144,6 +91,6 @@ class SoundRepository:
             return list(result.all())
         except Exception:
             logger.exception(
-                "Failed to get unnormalized sounds by type: %s", sound_type
+                "Failed to get unnormalized sounds by type: %s", sound_type,
             )
             raise