Refactor test cases for improved readability and consistency
All checks were successful
Backend CI / lint (push) Successful in 9m49s
Backend CI / test (push) Successful in 6m15s

- Adjusted function signatures in various test files to enhance clarity by aligning parameters.
- Updated patching syntax for better readability across test cases.
- Improved formatting and spacing in test assertions and mock setups.
- Ensured consistent use of async/await patterns in async test functions.
- Enhanced comments for better understanding of test intentions.
This commit is contained in:
JSC
2025-08-01 20:53:30 +02:00
parent d926779fe4
commit 6068599a47
39 changed files with 691 additions and 286 deletions

View File

@@ -32,7 +32,7 @@ async def get_sound_normalizer_service(
# SCAN ENDPOINTS
@router.post("/scan")
async def scan_sounds(
current_user: Annotated[User, Depends(get_admin_user)],
current_user: Annotated[User, Depends(get_admin_user)], # noqa: ARG001
scanner_service: Annotated[SoundScannerService, Depends(get_sound_scanner_service)],
) -> dict[str, ScanResults | str]:
"""Sync the soundboard directory (add/update/delete sounds). Admin only."""
@@ -53,11 +53,11 @@ async def scan_sounds(
@router.post("/scan/custom")
async def scan_custom_directory(
directory: str,
current_user: Annotated[User, Depends(get_admin_user)],
current_user: Annotated[User, Depends(get_admin_user)], # noqa: ARG001
scanner_service: Annotated[SoundScannerService, Depends(get_sound_scanner_service)],
sound_type: str = "SDB",
) -> dict[str, ScanResults | str]:
"""Sync a custom directory with the database (add/update/delete sounds). Admin only."""
"""Sync a custom directory with the database. Admin only."""
try:
results = await scanner_service.scan_directory(directory, sound_type)
except ValueError as e:
@@ -80,14 +80,15 @@ async def scan_custom_directory(
# NORMALIZE ENDPOINTS
@router.post("/normalize/all")
async def normalize_all_sounds(
current_user: Annotated[User, Depends(get_admin_user)],
current_user: Annotated[User, Depends(get_admin_user)], # noqa: ARG001
normalizer_service: Annotated[
SoundNormalizerService,
Depends(get_sound_normalizer_service),
],
*,
force: Annotated[
bool,
Query( # noqa: FBT002
Query(
description="Force normalization of already normalized sounds",
),
] = False,
@@ -119,14 +120,15 @@ async def normalize_all_sounds(
@router.post("/normalize/type/{sound_type}")
async def normalize_sounds_by_type(
sound_type: str,
current_user: Annotated[User, Depends(get_admin_user)],
current_user: Annotated[User, Depends(get_admin_user)], # noqa: ARG001
normalizer_service: Annotated[
SoundNormalizerService,
Depends(get_sound_normalizer_service),
],
*,
force: Annotated[
bool,
Query( # noqa: FBT002
Query(
description="Force normalization of already normalized sounds",
),
] = False,
@@ -167,14 +169,15 @@ async def normalize_sounds_by_type(
@router.post("/normalize/{sound_id}")
async def normalize_sound_by_id(
sound_id: int,
current_user: Annotated[User, Depends(get_admin_user)],
current_user: Annotated[User, Depends(get_admin_user)], # noqa: ARG001
normalizer_service: Annotated[
SoundNormalizerService,
Depends(get_sound_normalizer_service),
],
*,
force: Annotated[
bool,
Query( # noqa: FBT002
Query(
description="Force normalization of already normalized sound",
),
] = False,

View File

@@ -2,7 +2,7 @@
from typing import Annotated
from fastapi import APIRouter, Depends
from fastapi import APIRouter, Depends, HTTPException, status
from sqlmodel.ext.asyncio.session import AsyncSession
from app.core.database import get_db
@@ -110,7 +110,7 @@ async def update_playlist(
status_code=status.HTTP_401_UNAUTHORIZED,
detail="User ID not available",
)
playlist = await playlist_service.update_playlist(
playlist_id=playlist_id,
user_id=current_user.id,

View File

@@ -2,7 +2,7 @@
from typing import Annotated
from fastapi import APIRouter, Depends, HTTPException, Query, status
from fastapi import APIRouter, Depends, HTTPException, status
from sqlmodel.ext.asyncio.session import AsyncSession
from app.core.database import get_db, get_session_factory
@@ -18,7 +18,6 @@ from app.services.vlc_player import VLCPlayerService, get_vlc_player_service
router = APIRouter(prefix="/sounds", tags=["sounds"])
async def get_extraction_service(
session: Annotated[AsyncSession, Depends(get_db)],
) -> ExtractionService:
@@ -43,7 +42,6 @@ async def get_sound_repository(
return SoundRepository(session)
# EXTRACT
@router.post("/extract")
async def create_extraction(
@@ -60,7 +58,8 @@ async def create_extraction(
)
extraction_info = await extraction_service.create_extraction(
url, current_user.id,
url,
current_user.id,
)
# Queue the extraction for background processing
@@ -83,8 +82,6 @@ async def create_extraction(
}
@router.get("/extract/{extraction_id}")
async def get_extraction(
extraction_id: int,
@@ -206,7 +203,6 @@ async def play_sound_with_vlc(
}
@router.post("/stop")
async def stop_all_vlc_instances(
current_user: Annotated[User, Depends(get_current_active_user_flexible)], # noqa: ARG001