Refactor user endpoint tests to include pagination and response structure validation

- Updated tests for listing users to validate pagination and response format.
- Changed mock return values to include total count and pagination details.
- Refactored user creation mocks for clarity and consistency.
- Enhanced assertions to check for presence of pagination fields in responses.
- Adjusted test cases for user retrieval and updates to ensure proper handling of user data.
- Improved readability by restructuring mock definitions and assertions across various test files.

app/api/v1/playlists.py

@@ -5,7 +5,7 @@ from typing import Annotated, Any
 from fastapi import APIRouter, Depends, HTTPException, Query, status
 from sqlmodel.ext.asyncio.session import AsyncSession
 
-from app.core.database import get_db
+from app.core.database import get_db, get_session_factory
 from app.core.dependencies import get_current_active_user_flexible
 from app.models.user import User
 from app.repositories.playlist import PlaylistSortField, SortOrder
@@ -34,7 +34,6 @@ async def get_playlist_service(
 
 def get_favorite_service() -> FavoriteService:
     """Get the favorite service."""
-    from app.core.database import get_session_factory
     return FavoriteService(get_session_factory())
 
 
@@ -57,7 +56,7 @@ async def get_all_playlists(  # noqa: PLR0913
     ] = SortOrder.ASC,
     page: Annotated[int, Query(description="Page number", ge=1)] = 1,
     limit: Annotated[int, Query(description="Items per page", ge=1, le=100)] = 50,
-    favorites_only: Annotated[
+    favorites_only: Annotated[  # noqa: FBT002
         bool,
         Query(description="Show only favorited playlists"),
     ] = False,
@@ -78,15 +77,26 @@ async def get_all_playlists(  # noqa: PLR0913
     # Convert to PlaylistResponse with favorite indicators
     playlist_responses = []
     for playlist_dict in result["playlists"]:
-        # The playlist service returns dict, need to create playlist object-like structure
-        is_favorited = await favorite_service.is_playlist_favorited(current_user.id, playlist_dict["id"])
-        favorite_count = await favorite_service.get_playlist_favorite_count(playlist_dict["id"])
+        # The playlist service returns dict, need to create playlist object structure
+        playlist_id = playlist_dict["id"]
+        is_favorited = await favorite_service.is_playlist_favorited(
+            current_user.id, playlist_id,
+        )
+        favorite_count = await favorite_service.get_playlist_favorite_count(playlist_id)
 
         # Create a PlaylistResponse-like dict with proper datetime conversion
         playlist_response = {
             **playlist_dict,
-            "created_at": playlist_dict["created_at"].isoformat() if playlist_dict["created_at"] else None,
-            "updated_at": playlist_dict["updated_at"].isoformat() if playlist_dict["updated_at"] else None,
+            "created_at": (
+                playlist_dict["created_at"].isoformat()
+                if playlist_dict["created_at"]
+                else None
+            ),
+            "updated_at": (
+                playlist_dict["updated_at"].isoformat()
+                if playlist_dict["updated_at"]
+                else None
+            ),
             "is_favorited": is_favorited,
             "favorite_count": favorite_count,
         }
@@ -113,9 +123,13 @@ async def get_user_playlists(
     # Add favorite indicators for each playlist
     playlist_responses = []
     for playlist in playlists:
-        is_favorited = await favorite_service.is_playlist_favorited(current_user.id, playlist.id)
+        is_favorited = await favorite_service.is_playlist_favorited(
+            current_user.id, playlist.id,
+        )
         favorite_count = await favorite_service.get_playlist_favorite_count(playlist.id)
-        playlist_response = PlaylistResponse.from_playlist(playlist, is_favorited, favorite_count)
+        playlist_response = PlaylistResponse.from_playlist(
+            playlist, is_favorited, favorite_count,
+        )
         playlist_responses.append(playlist_response)
 
     return playlist_responses
@@ -129,7 +143,9 @@ async def get_main_playlist(
 ) -> PlaylistResponse:
     """Get the global main playlist."""
     playlist = await playlist_service.get_main_playlist()
-    is_favorited = await favorite_service.is_playlist_favorited(current_user.id, playlist.id)
+    is_favorited = await favorite_service.is_playlist_favorited(
+        current_user.id, playlist.id,
+    )
     favorite_count = await favorite_service.get_playlist_favorite_count(playlist.id)
     return PlaylistResponse.from_playlist(playlist, is_favorited, favorite_count)
 
@@ -142,7 +158,9 @@ async def get_current_playlist(
 ) -> PlaylistResponse:
     """Get the global current playlist (falls back to main playlist)."""
     playlist = await playlist_service.get_current_playlist()
-    is_favorited = await favorite_service.is_playlist_favorited(current_user.id, playlist.id)
+    is_favorited = await favorite_service.is_playlist_favorited(
+        current_user.id, playlist.id,
+    )
     favorite_count = await favorite_service.get_playlist_favorite_count(playlist.id)
     return PlaylistResponse.from_playlist(playlist, is_favorited, favorite_count)
 
@@ -172,7 +190,9 @@ async def get_playlist(
 ) -> PlaylistResponse:
     """Get a specific playlist."""
     playlist = await playlist_service.get_playlist_by_id(playlist_id)
-    is_favorited = await favorite_service.is_playlist_favorited(current_user.id, playlist.id)
+    is_favorited = await favorite_service.is_playlist_favorited(
+        current_user.id, playlist.id,
+    )
     favorite_count = await favorite_service.get_playlist_favorite_count(playlist.id)
     return PlaylistResponse.from_playlist(playlist, is_favorited, favorite_count)