Refactor user endpoint tests to include pagination and response structure validation

- Updated tests for listing users to validate pagination and response format.
- Changed mock return values to include total count and pagination details.
- Refactored user creation mocks for clarity and consistency.
- Enhanced assertions to check for presence of pagination fields in responses.
- Adjusted test cases for user retrieval and updates to ensure proper handling of user data.
- Improved readability by restructuring mock definitions and assertions across various test files.

app/schemas/auth.py

@@ -85,7 +85,8 @@ class ChangePasswordRequest(BaseModel):
     """Schema for password change request."""
 
     current_password: str | None = Field(
-        None, description="Current password (required if user has existing password)",
+        None,
+        description="Current password (required if user has existing password)",
     )
     new_password: str = Field(
         ...,
@@ -98,5 +99,8 @@ class UpdateProfileRequest(BaseModel):
     """Schema for profile update request."""
 
     name: str | None = Field(
-        None, min_length=1, max_length=100, description="User display name",
+        None,
+        min_length=1,
+        max_length=100,
+        description="User display name",
     )

app/schemas/favorite.py

@@ -11,10 +11,12 @@ class FavoriteResponse(BaseModel):
     id: int = Field(description="Favorite ID")
     user_id: int = Field(description="User ID")
     sound_id: int | None = Field(
-        description="Sound ID if this is a sound favorite", default=None,
+        description="Sound ID if this is a sound favorite",
+        default=None,
     )
     playlist_id: int | None = Field(
-        description="Playlist ID if this is a playlist favorite", default=None,
+        description="Playlist ID if this is a playlist favorite",
+        default=None,
     )
     created_at: datetime = Field(description="Creation timestamp")
     updated_at: datetime = Field(description="Last update timestamp")

app/schemas/playlist.py

@@ -39,14 +39,19 @@ class PlaylistResponse(BaseModel):
     updated_at: str | None
 
     @classmethod
-    def from_playlist(cls, playlist: Playlist, is_favorited: bool = False, favorite_count: int = 0) -> "PlaylistResponse":
+    def from_playlist(
+        cls,
+        playlist: Playlist,
+        is_favorited: bool = False,  # noqa: FBT001, FBT002
+        favorite_count: int = 0,
+    ) -> "PlaylistResponse":
         """Create response from playlist model.
-        
+
         Args:
             playlist: The Playlist model
             is_favorited: Whether the playlist is favorited by the current user
             favorite_count: Number of users who favorited this playlist
-            
+
         Returns:
             PlaylistResponse instance
 

app/schemas/sound.py

@@ -18,16 +18,20 @@ class SoundResponse(BaseModel):
     size: int = Field(description="File size in bytes")
     hash: str = Field(description="File hash")
     normalized_filename: str | None = Field(
-        description="Normalized filename", default=None,
+        description="Normalized filename",
+        default=None,
     )
     normalized_duration: int | None = Field(
-        description="Normalized duration in milliseconds", default=None,
+        description="Normalized duration in milliseconds",
+        default=None,
     )
     normalized_size: int | None = Field(
-        description="Normalized file size in bytes", default=None,
+        description="Normalized file size in bytes",
+        default=None,
     )
     normalized_hash: str | None = Field(
-        description="Normalized file hash", default=None,
+        description="Normalized file hash",
+        default=None,
     )
     thumbnail: str | None = Field(description="Thumbnail filename", default=None)
     play_count: int = Field(description="Number of times played")
@@ -35,10 +39,12 @@ class SoundResponse(BaseModel):
     is_music: bool = Field(description="Whether the sound is music")
     is_deletable: bool = Field(description="Whether the sound can be deleted")
     is_favorited: bool = Field(
-        description="Whether the sound is favorited by the current user", default=False,
+        description="Whether the sound is favorited by the current user",
+        default=False,
     )
     favorite_count: int = Field(
-        description="Number of users who favorited this sound", default=0,
+        description="Number of users who favorited this sound",
+        default=0,
     )
     created_at: datetime = Field(description="Creation timestamp")
     updated_at: datetime = Field(description="Last update timestamp")
@@ -50,7 +56,10 @@ class SoundResponse(BaseModel):
 
     @classmethod
     def from_sound(
-        cls, sound: Sound, is_favorited: bool = False, favorite_count: int = 0,
+        cls,
+        sound: Sound,
+        is_favorited: bool = False,  # noqa: FBT001, FBT002
+        favorite_count: int = 0,
     ) -> "SoundResponse":
         """Create a SoundResponse from a Sound model.
 
@@ -64,7 +73,8 @@ class SoundResponse(BaseModel):
 
         """
         if sound.id is None:
-            raise ValueError("Sound ID cannot be None")
+            msg = "Sound ID cannot be None"
+            raise ValueError(msg)
 
         return cls(
             id=sound.id,

app/schemas/user.py

@@ -7,7 +7,10 @@ class UserUpdate(BaseModel):
     """Schema for updating a user."""
 
     name: str | None = Field(
-        None, min_length=1, max_length=100, description="User full name",
+        None,
+        min_length=1,
+        max_length=100,
+        description="User full name",
     )
     plan_id: int | None = Field(None, description="User plan ID")
     credits: int | None = Field(None, ge=0, description="User credits")