Refactor user endpoint tests to include pagination and response structure validation

- Updated tests for listing users to validate pagination and response format.
- Changed mock return values to include total count and pagination details.
- Refactored user creation mocks for clarity and consistency.
- Enhanced assertions to check for presence of pagination fields in responses.
- Adjusted test cases for user retrieval and updates to ensure proper handling of user data.
- Improved readability by restructuring mock definitions and assertions across various test files.

app/services/favorite.py

@@ -49,12 +49,14 @@ class FavoriteService:
             # Verify user exists
             user = await user_repo.get_by_id(user_id)
             if not user:
-                raise ValueError(f"User with ID {user_id} not found")
+                msg = f"User with ID {user_id} not found"
+                raise ValueError(msg)
 
             # Verify sound exists
             sound = await sound_repo.get_by_id(sound_id)
             if not sound:
-                raise ValueError(f"Sound with ID {sound_id} not found")
+                msg = f"Sound with ID {sound_id} not found"
+                raise ValueError(msg)
 
             # Get data for the event immediately after loading
             sound_name = sound.name
@@ -63,9 +65,8 @@ class FavoriteService:
             # Check if already favorited
             existing = await favorite_repo.get_by_user_and_sound(user_id, sound_id)
             if existing:
-                raise ValueError(
-                    f"Sound {sound_id} is already favorited by user {user_id}",
-                )
+                msg = f"Sound {sound_id} is already favorited by user {user_id}"
+                raise ValueError(msg)
 
             # Create favorite
             favorite_data = {
@@ -120,12 +121,14 @@ class FavoriteService:
             # Verify user exists
             user = await user_repo.get_by_id(user_id)
             if not user:
-                raise ValueError(f"User with ID {user_id} not found")
+                msg = f"User with ID {user_id} not found"
+                raise ValueError(msg)
 
             # Verify playlist exists
             playlist = await playlist_repo.get_by_id(playlist_id)
             if not playlist:
-                raise ValueError(f"Playlist with ID {playlist_id} not found")
+                msg = f"Playlist with ID {playlist_id} not found"
+                raise ValueError(msg)
 
             # Check if already favorited
             existing = await favorite_repo.get_by_user_and_playlist(
@@ -133,9 +136,8 @@ class FavoriteService:
                 playlist_id,
             )
             if existing:
-                raise ValueError(
-                    f"Playlist {playlist_id} is already favorited by user {user_id}",
-                )
+                msg = f"Playlist {playlist_id} is already favorited by user {user_id}"
+                raise ValueError(msg)
 
             # Create favorite
             favorite_data = {
@@ -163,7 +165,8 @@ class FavoriteService:
 
             favorite = await favorite_repo.get_by_user_and_sound(user_id, sound_id)
             if not favorite:
-                raise ValueError(f"Sound {sound_id} is not favorited by user {user_id}")
+                msg = f"Sound {sound_id} is not favorited by user {user_id}"
+                raise ValueError(msg)
 
             # Get user and sound info before deletion for the event
             user_repo = UserRepository(session)
@@ -192,7 +195,8 @@ class FavoriteService:
             }
             await socket_manager.broadcast_to_all("sound_favorited", event_data)
             logger.info(
-                "Broadcasted sound_favorited event for sound %s removal", sound_id,
+                "Broadcasted sound_favorited event for sound %s removal",
+                sound_id,
             )
         except Exception:
             logger.exception(
@@ -219,9 +223,8 @@ class FavoriteService:
                 playlist_id,
             )
             if not favorite:
-                raise ValueError(
-                    f"Playlist {playlist_id} is not favorited by user {user_id}",
-                )
+                msg = f"Playlist {playlist_id} is not favorited by user {user_id}"
+                raise ValueError(msg)
 
             await favorite_repo.delete(favorite)
             logger.info(