Add tests for extraction API endpoints and enhance existing tests

- Implement tests for admin extraction API endpoints including status retrieval, deletion of extractions, and permission checks.
- Add tests for user extraction deletion, ensuring proper handling of permissions and non-existent extractions.
- Enhance sound endpoint tests to include duplicate handling in responses.
- Refactor favorite service tests to utilize mock dependencies for better maintainability and clarity.
- Update sound scanner tests to improve file handling and ensure proper deletion of associated files.

app/api/v1/admin/extractions.py

@@ -2,18 +2,58 @@
 
 from typing import Annotated
 
-from fastapi import APIRouter, Depends
+from fastapi import APIRouter, Depends, HTTPException, status
+from sqlmodel.ext.asyncio.session import AsyncSession
 
+from app.core.database import get_db
 from app.core.dependencies import get_admin_user
 from app.models.user import User
+from app.services.extraction import ExtractionService
 from app.services.extraction_processor import extraction_processor
 
 router = APIRouter(prefix="/extractions", tags=["admin-extractions"])
 
 
+async def get_extraction_service(
+    session: Annotated[AsyncSession, Depends(get_db)],
+) -> ExtractionService:
+    """Get the extraction service."""
+    return ExtractionService(session)
+
+
 @router.get("/status")
 async def get_extraction_processor_status(
     current_user: Annotated[User, Depends(get_admin_user)],  # noqa: ARG001
 ) -> dict:
     """Get the status of the extraction processor. Admin only."""
     return extraction_processor.get_status()
+
+
+@router.delete("/{extraction_id}")
+async def delete_extraction(
+    extraction_id: int,
+    current_user: Annotated[User, Depends(get_admin_user)],  # noqa: ARG001
+    extraction_service: Annotated[ExtractionService, Depends(get_extraction_service)],
+) -> dict[str, str]:
+    """Delete any extraction and its associated sound and files. Admin only."""
+    try:
+        deleted = await extraction_service.delete_extraction(extraction_id, None)
+
+        if not deleted:
+            raise HTTPException(
+                status_code=status.HTTP_404_NOT_FOUND,
+                detail=f"Extraction {extraction_id} not found",
+            )
+
+    except HTTPException:
+        # Re-raise HTTPExceptions without wrapping them
+        raise
+    except Exception as e:
+        raise HTTPException(
+            status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
+            detail=f"Failed to delete extraction: {e!s}",
+        ) from e
+    else:
+        return {
+            "message": f"Extraction {extraction_id} deleted successfully",
+        }

app/api/v1/extractions.py

@@ -170,7 +170,7 @@ async def get_processing_extractions(
     try:
         # Get all extractions with processing status
         processing_extractions = await extraction_service.extraction_repo.get_by_status(
-            "processing"
+            "processing",
         )
 
         # Convert to ExtractionInfo format
@@ -196,10 +196,53 @@ async def get_processing_extractions(
             }
             result.append(extraction_info)
 
-        return result
-
     except Exception as e:
         raise HTTPException(
             status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
             detail=f"Failed to get processing extractions: {e!s}",
         ) from e
+    else:
+        return result
+
+
+@router.delete("/{extraction_id}")
+async def delete_extraction(
+    extraction_id: int,
+    current_user: Annotated[User, Depends(get_current_active_user_flexible)],
+    extraction_service: Annotated[ExtractionService, Depends(get_extraction_service)],
+) -> dict[str, str]:
+    """Delete extraction and associated sound/files. Users can only delete their own."""
+    try:
+        if current_user.id is None:
+            raise HTTPException(
+                status_code=status.HTTP_401_UNAUTHORIZED,
+                detail="User ID not available",
+            )
+
+        deleted = await extraction_service.delete_extraction(
+            extraction_id, current_user.id,
+        )
+
+        if not deleted:
+            raise HTTPException(
+                status_code=status.HTTP_404_NOT_FOUND,
+                detail=f"Extraction {extraction_id} not found",
+            )
+
+    except ValueError as e:
+        raise HTTPException(
+            status_code=status.HTTP_403_FORBIDDEN,
+            detail=str(e),
+        ) from e
+    except HTTPException:
+        # Re-raise HTTPExceptions without wrapping them
+        raise
+    except Exception as e:
+        raise HTTPException(
+            status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
+            detail=f"Failed to delete extraction: {e!s}",
+        ) from e
+    else:
+        return {
+            "message": f"Extraction {extraction_id} deleted successfully",
+        }