feat: Refactor audio utility functions and update sound services to use shared methods
This commit is contained in:
@@ -82,7 +82,8 @@ class TestSoundNormalizerService:
|
||||
temp_path = Path(f.name)
|
||||
|
||||
try:
|
||||
hash_value = normalizer_service._get_file_hash(temp_path)
|
||||
from app.utils.audio import get_file_hash
|
||||
hash_value = get_file_hash(temp_path)
|
||||
assert len(hash_value) == 64 # SHA-256 hash length
|
||||
assert isinstance(hash_value, str)
|
||||
finally:
|
||||
@@ -96,30 +97,33 @@ class TestSoundNormalizerService:
|
||||
temp_path = Path(f.name)
|
||||
|
||||
try:
|
||||
size = normalizer_service._get_file_size(temp_path)
|
||||
from app.utils.audio import get_file_size
|
||||
size = get_file_size(temp_path)
|
||||
assert size > 0
|
||||
assert isinstance(size, int)
|
||||
finally:
|
||||
temp_path.unlink()
|
||||
|
||||
@patch("app.services.sound_normalizer.ffmpeg.probe")
|
||||
@patch("app.utils.audio.ffmpeg.probe")
|
||||
def test_get_audio_duration_success(self, mock_probe, normalizer_service):
|
||||
"""Test successful audio duration extraction."""
|
||||
mock_probe.return_value = {"format": {"duration": "123.456"}}
|
||||
|
||||
temp_path = Path("/fake/path/test.mp3")
|
||||
duration = normalizer_service._get_audio_duration(temp_path)
|
||||
from app.utils.audio import get_audio_duration
|
||||
duration = get_audio_duration(temp_path)
|
||||
|
||||
assert duration == 123456 # 123.456 seconds * 1000 = 123456 ms
|
||||
mock_probe.assert_called_once_with(str(temp_path))
|
||||
|
||||
@patch("app.services.sound_normalizer.ffmpeg.probe")
|
||||
@patch("app.utils.audio.ffmpeg.probe")
|
||||
def test_get_audio_duration_failure(self, mock_probe, normalizer_service):
|
||||
"""Test audio duration extraction failure."""
|
||||
mock_probe.side_effect = Exception("FFmpeg error")
|
||||
|
||||
temp_path = Path("/fake/path/test.mp3")
|
||||
duration = normalizer_service._get_audio_duration(temp_path)
|
||||
from app.utils.audio import get_audio_duration
|
||||
duration = get_audio_duration(temp_path)
|
||||
|
||||
assert duration == 0
|
||||
mock_probe.assert_called_once_with(str(temp_path))
|
||||
@@ -163,9 +167,9 @@ class TestSoundNormalizerService:
|
||||
with patch.object(normalizer_service, "_get_original_path") as mock_orig_path, \
|
||||
patch.object(normalizer_service, "_get_normalized_path") as mock_norm_path, \
|
||||
patch.object(normalizer_service, "_normalize_audio_two_pass") as mock_normalize, \
|
||||
patch.object(normalizer_service, "_get_audio_duration", return_value=6000), \
|
||||
patch.object(normalizer_service, "_get_file_size", return_value=2048), \
|
||||
patch.object(normalizer_service, "_get_file_hash", return_value="new_hash"):
|
||||
patch("app.services.sound_normalizer.get_audio_duration", return_value=6000), \
|
||||
patch("app.services.sound_normalizer.get_file_size", return_value=2048), \
|
||||
patch("app.services.sound_normalizer.get_file_hash", return_value="new_hash"):
|
||||
|
||||
# Setup path mocks
|
||||
mock_orig_path.return_value = Path("/fake/original.mp3")
|
||||
@@ -229,9 +233,9 @@ class TestSoundNormalizerService:
|
||||
with patch.object(normalizer_service, "_get_original_path") as mock_orig_path, \
|
||||
patch.object(normalizer_service, "_get_normalized_path") as mock_norm_path, \
|
||||
patch.object(normalizer_service, "_normalize_audio_one_pass") as mock_normalize, \
|
||||
patch.object(normalizer_service, "_get_audio_duration", return_value=5500), \
|
||||
patch.object(normalizer_service, "_get_file_size", return_value=1500), \
|
||||
patch.object(normalizer_service, "_get_file_hash", return_value="norm_hash"):
|
||||
patch("app.services.sound_normalizer.get_audio_duration", return_value=5500), \
|
||||
patch("app.services.sound_normalizer.get_file_size", return_value=1500), \
|
||||
patch("app.services.sound_normalizer.get_file_hash", return_value="norm_hash"):
|
||||
|
||||
# Setup path mocks
|
||||
mock_orig_path.return_value = Path("/fake/original.mp3")
|
||||
|
||||
Reference in New Issue
Block a user