Refactor scheduled task repository and schemas for improved type hints and consistency

- Updated type hints from List/Optional to list/None for better readability and consistency across the codebase.
- Refactored import statements for better organization and clarity.
- Enhanced the ScheduledTaskBase schema to use modern type hints.
- Cleaned up unnecessary comments and whitespace in various files.
- Improved error handling and logging in task execution handlers.
- Updated test cases to reflect changes in type hints and ensure compatibility with the new structure.

app/schemas/scheduler.py

@@ -1,7 +1,7 @@
 """Schemas for scheduled task API."""
 
 from datetime import datetime
-from typing import Any, Dict, Optional
+from typing import Any
 
 from pydantic import BaseModel, Field
 
@@ -15,7 +15,7 @@ class ScheduledTaskBase(BaseModel):
     task_type: TaskType = Field(description="Type of task to execute")
     scheduled_at: datetime = Field(description="When the task should be executed")
     timezone: str = Field(default="UTC", description="Timezone for scheduling")
-    parameters: Dict[str, Any] = Field(
+    parameters: dict[str, Any] = Field(
         default_factory=dict,
         description="Task-specific parameters",
     )
@@ -23,15 +23,15 @@ class ScheduledTaskBase(BaseModel):
         default=RecurrenceType.NONE,
         description="Recurrence pattern",
     )
-    cron_expression: Optional[str] = Field(
+    cron_expression: str | None = Field(
         default=None,
         description="Cron expression for custom recurrence",
     )
-    recurrence_count: Optional[int] = Field(
+    recurrence_count: int | None = Field(
         default=None,
         description="Number of times to repeat (None for infinite)",
     )
-    expires_at: Optional[datetime] = Field(
+    expires_at: datetime | None = Field(
         default=None,
         description="When the task expires (optional)",
     )
@@ -40,18 +40,17 @@ class ScheduledTaskBase(BaseModel):
 class ScheduledTaskCreate(ScheduledTaskBase):
     """Schema for creating a scheduled task."""
 
-    pass
 
 
 class ScheduledTaskUpdate(BaseModel):
     """Schema for updating a scheduled task."""
 
-    name: Optional[str] = None
-    scheduled_at: Optional[datetime] = None
-    timezone: Optional[str] = None
-    parameters: Optional[Dict[str, Any]] = None
-    is_active: Optional[bool] = None
-    expires_at: Optional[datetime] = None
+    name: str | None = None
+    scheduled_at: datetime | None = None
+    timezone: str | None = None
+    parameters: dict[str, Any] | None = None
+    is_active: bool | None = None
+    expires_at: datetime | None = None
 
 
 class ScheduledTaskResponse(ScheduledTaskBase):
@@ -59,11 +58,11 @@ class ScheduledTaskResponse(ScheduledTaskBase):
 
     id: int
     status: TaskStatus
-    user_id: Optional[int] = None
+    user_id: int | None = None
     executions_count: int
-    last_executed_at: Optional[datetime] = None
-    next_execution_at: Optional[datetime] = None
-    error_message: Optional[str] = None
+    last_executed_at: datetime | None = None
+    next_execution_at: datetime | None = None
+    error_message: str | None = None
     is_active: bool
     created_at: datetime
     updated_at: datetime
@@ -78,7 +77,7 @@ class ScheduledTaskResponse(ScheduledTaskBase):
 class CreditRechargeParameters(BaseModel):
     """Parameters for credit recharge tasks."""
 
-    user_id: Optional[int] = Field(
+    user_id: int | None = Field(
         default=None,
         description="Specific user ID to recharge (None for all users)",
     )
@@ -109,10 +108,10 @@ class CreateCreditRechargeTask(BaseModel):
     scheduled_at: datetime
     timezone: str = "UTC"
     recurrence_type: RecurrenceType = RecurrenceType.NONE
-    cron_expression: Optional[str] = None
-    recurrence_count: Optional[int] = None
-    expires_at: Optional[datetime] = None
-    user_id: Optional[int] = None
+    cron_expression: str | None = None
+    recurrence_count: int | None = None
+    expires_at: datetime | None = None
+    user_id: int | None = None
 
     def to_task_create(self) -> ScheduledTaskCreate:
         """Convert to generic task creation schema."""
@@ -137,9 +136,9 @@ class CreatePlaySoundTask(BaseModel):
     sound_id: int
     timezone: str = "UTC"
     recurrence_type: RecurrenceType = RecurrenceType.NONE
-    cron_expression: Optional[str] = None
-    recurrence_count: Optional[int] = None
-    expires_at: Optional[datetime] = None
+    cron_expression: str | None = None
+    recurrence_count: int | None = None
+    expires_at: datetime | None = None
 
     def to_task_create(self) -> ScheduledTaskCreate:
         """Convert to generic task creation schema."""
@@ -166,9 +165,9 @@ class CreatePlayPlaylistTask(BaseModel):
     shuffle: bool = False
     timezone: str = "UTC"
     recurrence_type: RecurrenceType = RecurrenceType.NONE
-    cron_expression: Optional[str] = None
-    recurrence_count: Optional[int] = None
-    expires_at: Optional[datetime] = None
+    cron_expression: str | None = None
+    recurrence_count: int | None = None
+    expires_at: datetime | None = None
 
     def to_task_create(self) -> ScheduledTaskCreate:
         """Convert to generic task creation schema."""
@@ -186,4 +185,4 @@ class CreatePlayPlaylistTask(BaseModel):
             cron_expression=self.cron_expression,
             recurrence_count=self.recurrence_count,
             expires_at=self.expires_at,
-        )
+        )